fix: reset module state on session_start to fix /new (daemon reconnect + fresh name) - #20
Merged
Merged
Conversation
The shuttingDown flag was set to true during session_shutdown but never reset to false. When /new starts a new session (same pi process, same extension module), connectToDaemon() immediately returns because shuttingDown is still true, leaving the agent status permanently at 'connecting to daemon...'. Fix: reset shuttingDown = false at the top of session_start handler. Co-authored-by: gentle-newt-20 <gentle-newt-20@pi-agent.local>
elecnix
marked this pull request as ready for review
July 6, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Typing
/newin a pi session causes two issues:🟡 <name> (connecting to daemon...)Root cause
Both stem from module-level variables that persist when
/newreuses the same pi process and extension module:shuttingDown— set totrueduringsession_shutdownbut never reset.connectToDaemon()returns immediately at its guard clause.agentName— retains the previous session's name. After the restore loop finds nothing in the new (empty) session file,if (!agentName)isfalse, sogenerateName()is never called.Fix
Reset both at the top of
session_start:Tested
/new, status transitions🟡 connecting→🟢 connected/new, agent name changes (e.g.shadow-raven-24→silver-quail-9)— gentle-newt-20